model: [WIP] explicit quantized layer #268
Draft
+148
−85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the quantization layer creation system to use explicit quantized layer classes instead of dynamically modifying linear layers. The changes introduce separate QIntLinear and QFloatLinear classes with their own forward methods, replacing the previous approach of monkey-patching forward methods onto existing layers.
Key changes:
- Introduction of explicit quantized layer classes (
QLinear,QIntLinear,QFloatLinear) - Refactored layer creation methods to use these new classes instead of dynamic modification
- Updated parameter handling to support proper data type management for scales
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/optimum/rbln/transformers/utils/rbln_quantization.py | Refactored quantization logic to use explicit layer classes and improved scale parameter handling |
| src/optimum/rbln/transformers/utils/qlinear.py | Added new quantized linear layer classes with explicit forward implementations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Type of Change
Changes Overview
Motivation and Context
Checklist
Additional Information
Related Issues
Conventional commit
Type candidate
model: Adding New models or Bugfix for existing modelsperformance: Optimizing some models or this library itselfrefactor: Re-arrange class architecture, or more.doc: Update docstring onlydependency: Update requirements, something like that.other: None of above.